Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Add a ClearDeadline API #162

Closed
schomatis opened this issue Aug 5, 2020 · 4 comments
Closed

Add a ClearDeadline API #162

schomatis opened this issue Aug 5, 2020 · 4 comments

Comments

@schomatis
Copy link

SetDeadline(time.Time) error
SetReadDeadline(time.Time) error
SetWriteDeadline(time.Time) error

(Same for read/write variants.)

@Stebalien
Copy link
Member

Call SetDeadline(time.Time{}) to clear the timeout. See the interface documentation in https://golang.org/pkg/net/#Conn.

@schomatis
Copy link
Author

Yeah, I'm aware of that, I had hope we could provide a more user-friendly API on this one.

@Stebalien Stebalien reopened this Aug 10, 2020
@Stebalien
Copy link
Member

I mean, we could, but then we'd have to implement it everywhere and we'd be deviating from the standard library at the same time. That's a lot of work/documentation for a papercut.

@schomatis
Copy link
Author

Fair enough, if this has many repercussions throughout other repos is not worth it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants