Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Adding metods to an interface is a breaking change. #23

Closed
Kubuxu opened this issue Jun 24, 2019 · 2 comments
Closed

Adding metods to an interface is a breaking change. #23

Kubuxu opened this issue Jun 24, 2019 · 2 comments

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Jun 24, 2019

By adding EventBus() method to Host interface and releasing 0.0.4 a lot of projects will stop to build after dependency update.

I would suggest considering an act of adding a method to an interface a breaking change and:

  1. be careful about it (first update and release the implementation)
  2. increase version number accordingly. As we are still in v0, this would mean incrementing minor version number.
@raulk
Copy link
Member

raulk commented Jun 24, 2019

Yeah, 100%. This is my bad. I should’ve:

  1. Released this with a minor version bump at the very least.
  2. Merged the go-libp2p PR quicker; we made significant changes to the eventbus last Friday, and the PR stayed dangling over the weekend.

Anyway, things should now be fixed. I released go-libp2p with both a patch bump for consistency, and a minor bump for correctness.

@raulk
Copy link
Member

raulk commented Jun 24, 2019

CC @lanzafame @prestonvanloon as affected parties.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants