Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANIC in queryPeer #334

Closed
vyzo opened this issue May 9, 2019 · 10 comments
Closed

PANIC in queryPeer #334

vyzo opened this issue May 9, 2019 · 10 comments

Comments

@vyzo
Copy link
Contributor

vyzo commented May 9, 2019

May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: panic: assignment to entry in nil map
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: goroutine 597169788 [running]:
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/jbenet/goprocess.(*process).AddChildNoWait(0xc6fcdd2060, 0xf86e20, 0xc6fd61bda0)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/jbenet/goprocess@v0.1.2/impl-mutex.go:72 +0x18d
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/jbenet/goprocess/context.WithProcessClosing(0xf7ce40, 0xc66f8b8b80, 0xf86e20, 0xc6fcdd2060, 0x0, 0x0)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/jbenet/goprocess@v0.1.2/context/context.go:85 +0x170
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/jbenet/goprocess/context.OnClosingContext(...)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/jbenet/goprocess@v0.1.2/context/derive.go:12
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).queryPeer(0xc45e460000, 0xf86e20, 0xc6fcdd2060, 0xc0be4f50b0, 0x22)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.10/query.go:270 +0x67
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).spawnWorkers.func1(0xf86e20, 0xc6fcdd2060)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.10/query.go:226 +0x50
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: github.com/jbenet/goprocess.(*process).Go.func1(0xc383fab5a0, 0xc6fcdd2060, 0xc6fcdd20c0)
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/jbenet/goprocess@v0.1.2/impl-mutex.go:112 +0x3c
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]: created by github.com/jbenet/goprocess.(*process).Go
May 09 18:27:19 ip-172-31-46-15 relay.sh[818]:         /home/ubuntu/go/pkg/mod/github.com/jbenet/goprocess@v0.1.2/impl-mutex.go:111 +0x1f7
@vyzo
Copy link
Contributor Author

vyzo commented May 9, 2019

cc @Stebalien

@Stebalien
Copy link
Member

@vyzo
Copy link
Contributor Author

vyzo commented May 10, 2019

Does this fix the panic or is it a bug in the dht?

@Stebalien
Copy link
Member

It was a bug in goprocess which is now fixed.

@vyzo
Copy link
Contributor Author

vyzo commented May 10, 2019

ok, closing.

@victorb
Copy link
Member

victorb commented May 17, 2019

Guessing this hasn't been released yet? Using libp2p/go-libp2p-kad-dht@v0.0.10 and just encountered the same issue

@Stebalien
Copy link
Member

Looks like I didn't tag a libp2p release.

@Stebalien
Copy link
Member

(transitive bug in dht -> libp2p -> goprocess)

@vyzo
Copy link
Contributor Author

vyzo commented May 17, 2019

care to use the github interface for tagging the release?

@Stebalien
Copy link
Member

Stebalien commented May 17, 2019

I can add release notes afterwards if we want. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants