Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestProvidesMany, TestPeriodicRefresh, TestFindPeerQuery and TestFindPeerWithQueryFilter fail on Windows machines #760

Closed
galargh opened this issue Jan 14, 2022 · 2 comments
Closed

TestProvidesMany, TestPeriodicRefresh, TestFindPeerQuery and TestFindPeerWithQueryFilter fail on Windows machines #760

galargh opened this issue Jan 14, 2022 · 2 comments

Comments

@galargh
Copy link
Contributor

galargh commented Jan 14, 2022 •
edited

TestProvidesMany never finishes on Windows machines. It keeps printing:

dht_test.go:956: Did not get a provider back (* at *)

TestPeriodicRefresh, TestFindPeerQuery and TestFindPeerWithQueryFilter panic after 10 minut timeout passes.

TestFindPeerQueryMinimal finishes quickly but is extremely flaky:

    dht_test.go:1392: connecting
    dht_test.go:1407: waiting for routing tables
    dht_test.go:620: avg rt size: 1
    dht_test.go:1412: refreshing
    dht_test.go:1425: waiting for routing tables again
    dht_test.go:1428: failed to reach well-formed routing tables after 5s
    dht_test.go:1435: querying
    dht_test.go:1446: got 4 peers
@galargh galargh changed the title TestProvidesMany times out on Windows machines TestProvidesMany, TestPeriodicRefresh and TestFindPeerQuery time out on Windows machines Jan 14, 2022
@galargh galargh changed the title TestProvidesMany, TestPeriodicRefresh and TestFindPeerQuery time out on Windows machines TestProvidesMany, TestPeriodicRefresh, TestFindPeerQuery and TestFindPeerWithQueryFilter fail on Windows machines Jan 14, 2022
@galargh
Copy link
Contributor Author

galargh commented Jan 14, 2022

I made these tests skip execution on Windows - dc316bb

This should be reverted once the original issue is addressed.

@galargh galargh mentioned this issue Jan 14, 2022
Open
@guillaumemichel
Copy link
Contributor

Doesn't seem to be the case anymore. Closing this issue. Feel free to reopen it should this issue occur again.

@guillaumemichel guillaumemichel mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galargh @guillaumemichel