Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchValue update peers with newer record #945

Closed
dennis-tra opened this issue Sep 28, 2023 · 1 comment
Closed

SearchValue update peers with newer record #945

dennis-tra opened this issue Sep 28, 2023 · 1 comment
Assignees
Labels
v2 All issues related to the v2 rewrite

Comments

@dennis-tra
Copy link
Contributor

dennis-tra commented Sep 28, 2023

When searching for an IPNS or PK record, we will store the updated version of that record with all the closest peers that we have found while querying. If the query aborts after the three closest haven't returned anyone closer, we still update the remaining 17 peers that we haven't contacted and store our currently known "best" record with them. However, these 17 peers may also hold the same record - we just don't know because we haven't contacted them yet.

I would change the logic in V2 to only store the updated record with peers that provably returned a stale record during the query operation.

@dennis-tra dennis-tra self-assigned this Sep 28, 2023
@dennis-tra dennis-tra added the v2 All issues related to the v2 rewrite label Sep 28, 2023
@iand
Copy link

iand commented Oct 2, 2023

Migrated to probe-lab/zikade#28

@iand iand closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 All issues related to the v2 rewrite
Projects
None yet
Development

No branches or pull requests

2 participants