Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Please Add A License #1

Closed
bonedaddy opened this issue Dec 31, 2018 · 3 comments
Closed

Please Add A License #1

bonedaddy opened this issue Dec 31, 2018 · 3 comments

Comments

@bonedaddy
Copy link

Hello, I saw your comment on an issue on the libp2p/go-libp2p#188, and would like to use this libp2p transport for an experimental feature in one of my projects. If that feature goes well, more than likely can contribute to this library as I would need to use it a lot.

Projects that do not include a license, are technically not usable by other projects https://choosealicense.com/no-permission/

Thanks!

@backkem
Copy link
Contributor

backkem commented Dec 31, 2018

Hi @postables. I added an MIT license. This repo is currently in a proof of concept stage.
I've been busy working on the core WebRTC library at pions/webrtc in the mean time. I do intent to get this library in a usable state at some point.

Some things I think need looking at:

  • Get some dependencies to land:
  • Determine if committing to pions/dcnet
  • Upgrade to a newer version of pions/webrtc.
  • Migrate to the Detach API (in pions/dcnet if keeping it).
  • Implement the libp2p interfaces correctly instead of relying on the *tptu.Upgrader.
  • Fix all the error handling I skipped.
  • Make the tests green.
  • Integration testing with js-libp2p-webrtc-direct

Long term I would prefer to contribute this library to the libp2p project itself, if/when they're willing to have it. You can also find me in the libp2p IRC or the Pion channel on the Golang slack if you have questions.

@bonedaddy
Copy link
Author

Awesome thank you! I'll be starting this project within the next 2-3 weeks, so if there's anything that should be tackled first let me know, otherwise i'll just poke around and open an issue if i find anything, or a pr if i see an immediate room for improvement.

Thanks for creating this library, will save a ton of initial work 🔥

@backkem
Copy link
Contributor

backkem commented Jan 8, 2019

Rewriting in #2 to fix the issues mentioned above.

@backkem backkem closed this as completed Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants