Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling typo #1123

Closed
lasselj opened this issue Jul 1, 2021 · 1 comment
Closed

Error handling typo #1123

lasselj opened this issue Jul 1, 2021 · 1 comment

Comments

@lasselj
Copy link
Contributor

lasselj commented Jul 1, 2021

go-libp2p/examples/multipro/ping.go

Line 99 in e5d5d44

proto.Unmarshal(buf, data)

It seems likely that it was the intention to handle the error on the following line. I.e. :

err = proto.Unmarshal(buf, data)

not
proto.Unmarshal(buf, data)
@marten-seemann
Copy link
Contributor

Good catch! Would you mind sending us a PR?

@lasselj lasselj mentioned this issue Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @marten-seemann @lasselj