Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: drop support for QUIC draft-29 #2369

Closed
Tracked by #2428
marten-seemann opened this issue Jun 15, 2023 · 2 comments
Closed
Tracked by #2428

quic: drop support for QUIC draft-29 #2369

marten-seemann opened this issue Jun 15, 2023 · 2 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@marten-seemann
Copy link
Contributor

This doesn't require a quic-go update including quic-go/quic-go#3903, we can just disable it in the quic.Config. See ipfs/kubo#9496 for context.
@marten-seemann marten-seemann added kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels Jun 15, 2023
@marten-seemann marten-seemann mentioned this issue Jun 15, 2023
Closed
29 tasks
@p-shahi
Copy link
Member

p-shahi commented Jun 27, 2023

quic-v1 was added 6 months ago in 0.24.0 https://github.com/libp2p/go-libp2p/releases/tag/v0.24.0
There will be failures in nodes that only support draft-29, the nodes that don't speak quic-v1 will instead dial using TCP.
This is in scope for kubo 0.22 per https://github.com/orgs/ipfs/projects/16/views/3?filterQuery=iteration%3A%22kubo+0.22%22+quic

@p-shahi p-shahi mentioned this issue Jun 29, 2023
Merged
@marten-seemann marten-seemann mentioned this issue Jul 14, 2023
Closed
21 tasks
@dindinw dindinw mentioned this issue Aug 10, 2023
Closed
@bahner bahner mentioned this issue Aug 14, 2023
Closed
@p-shahi
Copy link
Member

p-shahi commented Aug 24, 2023

done in #2487

@p-shahi p-shahi closed this as completed Aug 24, 2023
@mxinden mxinden mentioned this issue Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marten-seemann @p-shahi