Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate or improve documentation for crypto.GenerateEKeyPair #2709

Closed
sukunrt opened this issue Feb 16, 2024 · 3 comments
Closed

Deprecate or improve documentation for crypto.GenerateEKeyPair #2709

sukunrt opened this issue Feb 16, 2024 · 3 comments

Comments

@sukunrt
Copy link
Member

sukunrt commented Feb 16, 2024

In dropping support for go1.20 I came across crypto.GenerateEKeyPair. https://github.com/libp2p/go-libp2p/blob/master/core/crypto/key.go#L129

It looks like no one is using this and some time in the past it was used for SECIO. It also has the cryptic comment Used in the identify module.

@marten-seemann @Stebalien any details you can share about this?

@Stebalien
Copy link
Member

Yeah, it was used in secio for forward secrecy. IMO, it can safely be removed and nobody's likely to care.

@Stebalien
Copy link
Member

(search of local code + grep.app revealed no users other than secio)

@sukunrt
Copy link
Member Author

sukunrt commented Feb 21, 2024

fixed by #2711

@sukunrt sukunrt closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants