Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be smarter when using MDNS #376

Open
Stebalien opened this issue Jul 23, 2018 · 3 comments
Open

Be smarter when using MDNS #376

Stebalien opened this issue Jul 23, 2018 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@Stebalien
Copy link
Member

We should:

  1. Iterate over all the interfaces we're listening on that support multicast.
  2. Figure out what IP addresses we have assigned on those interfaces.
  3. Look up the IP in our host's listen addresses.
  4. Figure out the correct port to announce.
  5. Announce that port over the correct interface.

However, this means we'll need to manage multiple mdns "servers".

@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Jul 23, 2018
@gpestana
Copy link
Contributor

Will this issue be resolved by #285 or is it blocked by it?

@Stebalien
Copy link
Member Author

Blocked by it. It's the "next step". Unfortunately, that PR is blocked because, unless I'm mistaken, it doesn't fix the issue that prompted switching libraries (memory unsafety in the underlying library).

@gpestana
Copy link
Contributor

Ok, sounds good. I will keep an eye on this issue and if needed I can look into it when it gets unblocked. In the meanwhile I created an example of how to use go-libp2p mDNS discovery as is nowadays (libp2p/go-libp2p-examples#2). It seems that the high level interface will not change, so I believe that the example will still be relevant when both #285 and this issue are solved.

@MarcoPolo MarcoPolo added exp/expert Having worked on the specific codebase is important P3 Low: Not priority right now and removed help wanted Seeking public contribution on this issue labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants