Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify test failure #478

Closed
Stebalien opened this issue Nov 8, 2018 · 1 comment · Fixed by #479
Closed

Identify test failure #478

Stebalien opened this issue Nov 8, 2018 · 1 comment · Fixed by #479
Assignees
@Stebalien

Comments

@Stebalien
Copy link
Member

For some reason, it looks like the peerstore doesn't know it's own address? ??? Looks almost like it's related to #473 but that should just be a mock net issue...

id_test.go:54: test peer1 has peer2 addrs correctly
id_test.go:71: test peer2 has peer1 addrs correctly
id_test.go:94: expected: []
id_test.go:94: actual: [/ip4/127.0.0.1/tcp/33257]
id_test.go:94: dont have the same addresses
@Stebalien
Copy link
Member Author

Stebalien commented Nov 8, 2018 •
edited

Nvm. Just looks like a racy test. Timers firing early?

@Stebalien Stebalien mentioned this issue Nov 8, 2018
Merged
@ghost ghost assigned Stebalien Nov 8, 2018
@ghost ghost added the status/in-progress In progress label Nov 8, 2018
@ghost ghost removed the status/in-progress In progress label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deflake identify test libp2p/go-libp2p
1 participant
@Stebalien