Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer I can filter/blacklist peers #620

Closed
frrist opened this issue May 2, 2019 · 1 comment
Closed

As a developer I can filter/blacklist peers #620

frrist opened this issue May 2, 2019 · 1 comment

Comments

@frrist
Copy link
Member

frrist commented May 2, 2019

Description

In go-filecoin when a node fails the hello protocol (because they have a different genesis block or wrong version) we disconnect from them. However, we will frequently reconnect to them immediately. This is undesirable as we would prefer to not reconnect to this peer again for some time.
A solution we initially considered was the Backoff method in go-libp2p-swarm, but we were informed this component is for internal use only.

Acceptance criteria

  • As a developer I can configure my application to:
    • avoid reconnecting to a peer for some configurable amount of time. (e.g. in go-filecoin a peer may keep the same peerID but update its version, we would not want to blacklist a peer in this scenario).
    • Completely blacklist a peer from reconnecting.
@aschmahmann
Copy link
Contributor

This closed by #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants