Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gopacket/gopacket #41

Open
shaunco opened this issue Feb 24, 2024 · 4 comments
Open

Switch to gopacket/gopacket #41

shaunco opened this issue Feb 24, 2024 · 4 comments

Comments

@shaunco
Copy link

shaunco commented Feb 24, 2024

Please switch from https://github.com/google/gopacket to https://github.com/gopacket/gopacket

@willscott
Copy link
Contributor

this library is able to be used as a standalone component, but is also commonly used as part of https://github.com/libp2p/go-libp2p/blob/master/go.mod#L12

as such, this is a decision i would want to do as part of a migration at the libp2p level, rather than introduce the change of the alternate dep only in this sub-library.

is there a reason the gopacket fork was not created as a fork of the upstream library on github? it doesn't show up in the network of the google library, which makes it harder to identify as a clear direct successor,

@sruehl
Copy link

sruehl commented Feb 26, 2024

maybe @mosajjal can answer the fork question

@mosajjal
Copy link

the gopacket/gopacket project is not a git-level fork of google/gopacket because Google has shown no intention of merging the changes back to the original repo. having it as a standalone repository helps developers fork gopacket/gopacket and contribute directly.

hope that clears it up.

@willscott
Copy link
Contributor

I see no issue about it in google/gopacket - where was that lack of interest shown by previous maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants