Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multiaddrs instead of UNIX socket paths for daemon sockets #9

Closed
Tracked by #5
vasco-santos opened this issue Feb 13, 2019 · 0 comments · Fixed by #10
Closed
Tracked by #5

Use multiaddrs instead of UNIX socket paths for daemon sockets #9

vasco-santos opened this issue Feb 13, 2019 · 0 comments · Fixed by #10
Assignees
@jacobheun
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

The current implementation of js-libp2p-daemon expects unix socket paths, while go-libp2p-daemon has evolved to use multiaddrs for these paths.

In this context, the -sock cli parameter was also modified to -listen. This way, when people want to switch between daemons, they have to switch the params names, which is not good.

Reference: libp2p/go-libp2p-daemon#41
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up labels Feb 13, 2019
@jacobheun jacobheun added help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Feb 14, 2019
This was referenced Feb 19, 2019
Closed
Closed
Closed
@jacobheun jacobheun self-assigned this Feb 25, 2019
@jacobheun jacobheun mentioned this issue Feb 25, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for unix multiaddr listen libp2p/js-libp2p-daemon
2 participants
@jacobheun @vasco-santos