This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix: ensure timeline.close is set #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be resolved first License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
They are generated and uploaded on release License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest
interface-transportincludes tests to ensure timeline values are set properly. This exposed a bug where we did not setclosewhen the socket ended without callingcloseon the MultiaddrConnection explicitly. This fixes that by listening for the close event on the socket from the start.I removed
multiaddr('/dns4/ipfs.io')from the compliance list of addresses.filteris now tested ininterface-transportand it shows that this is not a valid TCP address. DNS addresses should be resolved into TCP addresses before being passed to the transport.