This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: add path multiaddr support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
suggested changes
Dec 5, 2019
test/listen-dial.spec.js
Outdated
| it('listen on path', async () => { | ||
| // Windows doesn't support unix paths | ||
| const mh = isWindows | ||
| ? multiaddr('/ip4/0.0.0.0/tcp/8080') |
There was a problem hiding this comment.
should we just skip this test in windows instead?
There was a problem hiding this comment.
yeah, that make more sense
test/listen-dial.spec.js
Outdated
| @@ -192,6 +196,29 @@ describe('dial', () => { | |||
| await listener.close() | |||
| }) | |||
|
|
|||
| it('dial on path', async () => { | |||
| // Windows doesn't support unix paths | |||
| const ma = isWindows | |||
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
reviewed
Dec 5, 2019
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.