Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass autodial config thorugh in connection manager init #2523

Merged
merged 1 commit into from
May 7, 2024

Conversation

oott123
Copy link
Contributor

@oott123 oott123 commented May 5, 2024

Title

fix: options in connection manager init should be passed to autodial

Description

autoDialPeerRetryThreshold and autoDialDiscoveredPeersDebounce should be passed from connection manager to auto dial, otherwise it won't work

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

that is, autoDialPeerRetryThreshold and autoDialDiscoveredPeersDebounce should be passed to auto dial, otherwise it won't work
@oott123 oott123 requested a review from a team as a code owner May 5, 2024 06:58
@achingbrain achingbrain changed the title fix: options in connection manager init should be passed to autodial fix: pass autodial config thorugh in connection manager init May 7, 2024
@achingbrain achingbrain merged commit 767b23e into libp2p:main May 7, 2024
20 checks passed
@achingbrain
Copy link
Member

Thanks!

@achingbrain achingbrain mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants