fix: use xor-compare for finding closer peers #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches from array compare to xor compare as this is how we're supposed to measure distance between two peers. Also stores `PeerInfo`s in peer distance list instead of `PeerId`s so to not lose the peers found in a query that are not in the peer store yet.
SgtPooki
approved these changes
May 10, 2024
| import { convertPeerId, getDistance } from '../utils.js' | ||
| import type { PeerId } from '@libp2p/interface' | ||
| import { xor as uint8ArrayXor } from 'uint8arrays/xor' | ||
| import { xorCompare as uint8ArrayXorCompare } from 'uint8arrays/xor-compare' |
There was a problem hiding this comment.
for future reference, this was added in achingbrain/uint8arrays#89
maschad
requested changes
May 11, 2024
| peerId: PeerId | ||
| distance: bigint | ||
| peer: PeerInfo | ||
| distance: Uint8Array |
There was a problem hiding this comment.
If this ends up getting converted to a bigint what's the rationale behind changing these to Uint8Array ?
There was a problem hiding this comment.
You're linking to main there - it no longer gets converted to a bigint, instead the Uint8Arrays are the xor distances that get compared using xorCompare.
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
This was referenced May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from array compare to xor compare as this is how we're supposed to measure distance between two peers.
Also stores
PeerInfos in peer distance list instead ofPeerIds so to not lose the peers found in a query that are not in the peer store yet.Change checklist