Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant isPeerId function #88

Open
vasco-santos opened this issue Oct 30, 2018 · 0 comments
Open

Redundant isPeerId function #88

vasco-santos opened this issue Oct 30, 2018 · 0 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

After adding the class-is module with js-peer-id#84, the isPeerId function is redundant and can be removed js-peer-id/index.js#L291-L295.

Note: this was not removed with the addition of class-is since it is a breaking change and will need to change all its usages.
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vasco-santos