Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android example as a gradle module #270

Closed
Nashatyrev opened this issue Feb 24, 2023 · 1 comment · Fixed by #275
Closed

Add Android example as a gradle module #270

Nashatyrev opened this issue Feb 24, 2023 · 1 comment · Fixed by #275
Labels
good first issue Good for newcomers

Comments

@Nashatyrev
Copy link
Collaborator

jvm-Libp2p was converted to multi-module gradle project and the examples were added as submodules except of Android example

Would be good to have it integrated as well.
Some requirements:

  • it should be skipped by gradle if no Android SDK is installed. I.e. it should work as before for those unaware of Android
  • the module should be correctly imported to IntelliJ IDEA whenever Android SDK/Tools/Plugins installed or not
@Nashatyrev Nashatyrev added the good first issue Good for newcomers label Feb 24, 2023
@Nashatyrev
Copy link
Collaborator Author

Fixed with #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant