Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing functionality to JS libp2p libraries #64

Closed
Mikerah opened this issue Jan 17, 2019 · 2 comments
Closed

Adding some missing functionality to JS libp2p libraries #64

Mikerah opened this issue Jan 17, 2019 · 2 comments

Comments

@Mikerah
Copy link

Mikerah commented Jan 17, 2019

Hi from the ChainSafe team!

This year, we have started implementing gossipsub in JS. The gossipsub specification isn't enough (maybe, I'm too spoilt by the ETH2.0 specs) to start implementing from scratch. As such, we are going off the Go implementation of the protocol.

While going through the Go implementation and trying to make sure we stick as much as we can to its functionality in JS, we realized that there is quite of bit of disparity between some of the same Go and JS modules.

We are planning on adding the needed functionality before we continue on with our Gossipsub implementation.

Were there any plans to do so for this year from the libp2p team? We are definitely interested in collaborating.

@raulk
Copy link
Member

raulk commented Jan 18, 2019

Totally! As a first stab, it would be great to collaborate to identify/solve those areas of disparity. I know @jacobheun and @vasco-santos already keep an account in their heads, but it might be worth working together on an enumeration to gain alignment. Some things might be different by design, while others will definitely need levelling up.

@Mikerah, do you guys already have a list of what you’ve identified on your end?

@Mikerah
Copy link
Author

Mikerah commented Jan 18, 2019

I have started a separate issue in our gossipsub repo. It's a start but I will be more specific as I start identifying the exact changes.

@Mikerah Mikerah closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants