Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce TTL for peer data record #371

Open
NIC619 opened this issue Nov 30, 2019 · 0 comments
Open

Enforce TTL for peer data record #371

NIC619 opened this issue Nov 30, 2019 · 0 comments

Comments

@NIC619
Copy link
Contributor

NIC619 commented Nov 30, 2019

What was wrong?

Open this issue to track the TODO here:

def add_addrs(self, peer_id: ID, addrs: Sequence[Multiaddr], ttl: int) -> None:
"""
:param peer_id: peer ID to add address for
:param addrs:
:param ttl: time-to-live for the this record
"""
# Ignore ttl for now

as brought up in the comment in: #360 (comment)

How can it be fixed?

When requested, check if the peer data has expired. Delete it and raise PeerStoreError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant