Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace get_if_addrs with a pure Rust library #1489

Closed
tomaka opened this issue Mar 10, 2020 · 5 comments
Closed

Replace get_if_addrs with a pure Rust library #1489

tomaka opened this issue Mar 10, 2020 · 5 comments

Comments

@tomaka
Copy link
Member

tomaka commented Mar 10, 2020

For the sake of not having to compile any C code, let's try use only pure Rust dependencies.

@mxinden
Copy link
Member

mxinden commented Mar 10, 2020

We could use libpnet's interfaces instead which for unix would use the systems libc instead of custom C code.

@Demi-Marie
Copy link
Contributor

Once https://github.com/paritytech/ip-watch is ready, this will be solved.

@kallisti5
Copy link

It looks like this one is solved? Having trouble building apps using rust-libp2p 0.22.0 because of poor "non-linux" support. get_if_addrs is also now read-only and not accepting patches / fixes.

@mxinden
Copy link
Member

mxinden commented Dec 10, 2020

It looks like this one is solved?

Not quite. I am afraid it gotten even more complicated.

With #1830 libp2p-mdns now uses if-wtach which uses a Rust implementation on Linux and Windows and falls back to if-addrs on e.g. Mac.

libp2p-tcp still uses if-addr which might change to if-watch with #1845.

@dvc94ch
Copy link
Contributor

dvc94ch commented Dec 29, 2021

this one can be closed now, no?

@mxinden mxinden closed this as completed Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants