Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossipsub: Re-write tests to remove technical debt #3371

Open
thomaseizinger opened this issue Jan 24, 2023 · 4 comments
Open

gossipsub: Re-write tests to remove technical debt #3371

thomaseizinger opened this issue Jan 24, 2023 · 4 comments
Labels
difficulty:moderate help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

With #3327, we took out some technical debt to move forward with #2824. The tests which currently depend on ConnectionId should be refactored to spin up a Swarm and establish an actual connection which will then allow us to remove ConnectionId::DUMMY.
@thomaseizinger thomaseizinger mentioned this issue Jan 24, 2023
Merged
4 tasks
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@dgarus
Copy link
Contributor

dgarus commented Mar 12, 2023

@thomaseizinger
Hello, Thomas!

I tried to find a comment with the issue number, but couldn't.
Is something changed?
I would like to try to make this issue.

Thanks!

@thomaseizinger
Copy link
Contributor Author

Thanks for wanting to tackle this!

You can also search for all usages of ConnectionId::DUMMY, that should you lead to the same code places that need fixing!

@thomaseizinger
Copy link
Contributor Author

Usages of ConnectionId::DUMMY are being replaced in #3652. We still want to rewrite those tests to create Swarms instead though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaseizinger @dgarus