Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the MultiaddrFuture in favor of a simple Multiaddr in Transport #487

Closed
tomaka opened this issue Sep 17, 2018 · 2 comments
Closed

Remove the MultiaddrFuture in favor of a simple Multiaddr in Transport #487

tomaka opened this issue Sep 17, 2018 · 2 comments
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Sep 17, 2018

After #486, there's no reason for the multiaddr produced by the Transport to be a future anymore.

Therefore it should be replaced with a simple Multiaddr.
Additionally, the Listener can produce that Multiaddr instead of the ListenerUpgrade.

The API of the new swarm should also be simplified in the process.

Depends on #486
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:moderate on-ice labels Sep 17, 2018
This was referenced Sep 28, 2018
Closed
Closed
@jamesray1 jamesray1 mentioned this issue Oct 24, 2018
Merged
@jamesray1
Copy link
Contributor

I believe this has been done in #568?

@tomaka
Copy link
Member Author

tomaka commented Oct 24, 2018

Indeed!

@tomaka tomaka closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomaka @jamesray1