Don't force close connections if ping protocol is not supported by remote #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
ping-no-failure
branch
from
28fe685
to
80ef250
Compare
thomaseizinger
force-pushed
the
ping-no-failure
branch
from
80ef250
to
bc5a845
Compare
thomaseizinger
force-pushed
the
ping-no-failure
branch
from
bc5a845
to
24cb5b3
Compare
mxinden
reviewed
Jul 23, 2021
| @@ -189,6 +189,52 @@ fn max_failures() { | |||
| QuickCheck::new().tests(10).quickcheck(prop as fn(_,_)) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn unsupported_doesnt_fail() { | |||
thomaseizinger
commented
Jul 26, 2021
`State` is explanatory enough and this is a private item.
mxinden
reviewed
Jul 26, 2021
|
Sorry for the failed build. Not yet used to my new RA-based setup. |
|
Still some CI failures which I can not tackle via GitHub suggestions. Can you take another look @thomaseizinger? |
|
@mxinden I had to switch the |
mxinden
reviewed
Jul 28, 2021
Making this configurable also allows us to delete some code from the relay tests.
mxinden
approved these changes
Jul 30, 2021
| } | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct KeepAliveBehaviour { |
There was a problem hiding this comment.
Thank you @thomaseizinger. Past-me should have done more research before writing this 😇
There was a problem hiding this comment.
I think a libp2p-test crate is desperately needed :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2109.