Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rendezvous] How exactly does Unregister work? #335

Closed
thomaseizinger opened this issue Jun 20, 2021 · 0 comments · Fixed by #348
Closed

[Rendezvous] How exactly does Unregister work? #335

thomaseizinger opened this issue Jun 20, 2021 · 0 comments · Fixed by #348

Comments

@thomaseizinger
Copy link
Contributor

The spec is fairly thin on the behaviour of Unregister.

I am opening this issue to discuss primarily two aspects:

  1. According to af5ba41, the id in the Unregister message is the PeerId. Why do we need to send this? We know who is sending the message because our connection is authenticated.
  2. Is there a response to an Unregister message? I don't think there needs to be because there is no useful information the server can share with the client.

Tagging interest group + author: @daviddias, @whyrusleeping, @Stebalien, @jacobheun, @yusefnapora, @vasco-santos, @vyzo (Please let me know if one shouldn't do this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant