Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping/_compositions/rust: Add v0.49.0 and update features of master #59

Closed
mxinden opened this issue Oct 20, 2022 · 1 comment · Fixed by #60
Closed

ping/_compositions/rust: Add v0.49.0 and update features of master #59

mxinden opened this issue Oct 20, 2022 · 1 comment · Fixed by #60

Comments

@mxinden
Copy link
Member

mxinden commented Oct 20, 2022

With libp2p/rust-libp2p#3001 master is now v0.50.0 AND removes the dns-async-std etc. features.

This results in test failures, see e.g. libp2p/rust-libp2p#3047.

We need to do the upgrade of libp2p/test-plans similar to #41.

Most prominently, we need to update the versions below:

[master]
CargoFeatures = 'libp2pmaster'
[custom]
CargoFeatures = 'libp2pmaster'
[[groups]]
Id = '0.48.0'
CargoFeatures = 'libp2pv0480'

and update the `Cargo.toml.

//CC the rust-libp2p team @thomaseizinger @jxs @elenaf9 for visibility and in case one of you wants to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants