Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Messages are not rendered in the frontend when sent via the go-peer #10

Closed
p-shahi opened this issue Apr 3, 2023 · 0 comments · Fixed by #26
Closed

bug: Messages are not rendered in the frontend when sent via the go-peer #10

p-shahi opened this issue Apr 3, 2023 · 0 comments · Fixed by #26
Assignees

Comments

@p-shahi
Copy link
Member

p-shahi commented Apr 3, 2023

@2color :

I did some testing of the go-peer.
There’s a bug that I think we saw with Rust where sometimes messages aren’t rendered in the frontend even though there’s a log in the frontend saying RPC gossipsub:
https://share.descript.com/view/rXxz0yCOHjF

@p-shahi :

This issue occurred with the rust peer since it was sending each message with the same sequence number. Js-libp2p-gossipsub’s default behavior was to use the sequence number to deduplicate messages and since the numbers were the same it was discarding some messages received. Adding the message ID function in js-libp2p-gossipsub fixed it.
I don’t think it’s the same issue since the same message ID function will be applied to all incoming messages regardless of go or rust peer. Can try to dig into this today.

@p-shahi p-shahi self-assigned this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant