Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

特意 #ifdef __cplusplus extern "C" { #endif 前加 "namespace gfx" 是...??? #2

Open
yrom opened this issue Mar 7, 2024 · 0 comments

Comments

@yrom
Copy link

yrom commented Mar 7, 2024

skcms/skcms.h

Lines 21 to 25 in 8ca9333

namespace gfx {
#ifdef __cplusplus
extern "C" {
#endif

对比了skia 原始仓库的 skcms.h https://skia.googlesource.com/skia/+/2f1f21b8a976e9177d03149e3b98e06f05bb2cd1/include/third_party/skcms/skcms.h#21

如果一开始是为了解决符号冲突问题,那不是加了 namespace gfx 之后将

#ifdef __cplusplus
extern "C" {
#endif

删了就好了吗。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant