Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.23.0 #387

Closed
kacejot opened this issue Oct 21, 2019 · 13 comments
Closed

Release v0.23.0 #387

kacejot opened this issue Oct 21, 2019 · 13 comments

Comments

@kacejot
Copy link

kacejot commented Oct 21, 2019

Hi guys,
How soon the new release is supposed to happen?
I'm waiting for pnet::transport::IcmpTransportChannelIterator::next_with_timeout on stable.
Could you also give me a stable revision with this feature, so I could use it instead of master branch?

@JuxhinDB
Copy link
Member

Hi @kacejot -- unfortunately it looks like this project isn't really being maintained any longer. I would've loved to help contribute further, however I still would need mentorship from the original authors (and time) which makes this difficult to achieve.

If it's something you think you can help with, feel free to open an PR and I'll review it and we can merge.

@mrmonday
Copy link
Contributor

@JuxhinDB I can give you access to publish to crates.io if you don't already have it.

Take a look at previous "bump version" PRs for what needs doing - basically just bump up version numbers in toml files and the README, then follow the normal cargo publish procedure (I try to make sure to do this in a fresh clone so that other files don't get published by accident).

@mrmonday
Copy link
Contributor

Re: mentorship, I'm always happy to help if you have specific questions. I might be a little slow to respond, but I will help if I can.

@JuxhinDB
Copy link
Member

@mrmonday feel free to provide me with access. If you need details you should be able to DM me on twitter (@JuxhinDB). I can then take it from there and try to handle the release. Thanks!

@mrmonday
Copy link
Contributor

@JuxhinDB I've sent invites to you for (hopefully) all the pnet* crates on crates.io - let me know if I've missed any.

@JuxhinDB
Copy link
Member

@mrmonday Seems to be all of them. Thank you :-)

@kacejot
Copy link
Author

kacejot commented Oct 24, 2019

@JuxhinDB, so you're in charge here now :) What are your thoughts about making new release?

@JuxhinDB
Copy link
Member

Apologies for the late reply. :-)

I'm setting a reminder to look into this later this week (ideally today) to come up with an idea on how to proceed. Hopefully we'll have this done soon enough

@JuxhinDB
Copy link
Member

JuxhinDB commented Nov 6, 2019

Apologies for the late reply regarding this. Opened PR - #390

@mrmonday let me know if anything seems off. I'll give it some time then I'll merge

Edit: You can ignore current build. Forgot I actually had to publish first. 🙃

@JuxhinDB
Copy link
Member

JuxhinDB commented Nov 6, 2019

Looks good to go. Forgot to squash commits but hopefully that isn't an issue. I'll leave the issue open to make sure that things still work for you guys

@mrmonday
Copy link
Contributor

mrmonday commented Nov 6, 2019

I think the only thing missing is the git tag, otherwise looks good :)

Thank you @JuxhinDB!

@JuxhinDB
Copy link
Member

JuxhinDB commented Nov 6, 2019

@mrmonday Drafted and released one now. I just tied it with the source code (no additional binaries). Pleasure to help

@kacejot
Copy link
Author

kacejot commented Nov 7, 2019

@JuxhinDB, thanks a lot!
I think we can close this one for now.

@JuxhinDB JuxhinDB closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants