Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding /v1 for JSONRPC endpoint. #5147

Closed
wants to merge 1 commit into from
Closed

Adding /v1 for JSONRPC endpoint. #5147

wants to merge 1 commit into from

Conversation

thefallentree
Copy link
Contributor

Create an /v1 endpoint , but for now still allows user to use "/"

in the future PR we will start to redirect "/" to latest "/vX" .

@thefallentree thefallentree requested a review from xli July 16, 2020 19:26
@xli
Copy link
Contributor

xli commented Jul 16, 2020

do we need also update testsuites/cli?

@thefallentree
Copy link
Contributor Author

@bors-libra r=xli

@bors-libra
Copy link
Contributor

📌 Commit f9995f2 has been approved by xli

@bors-libra
Copy link
Contributor

⌛ Testing commit f9995f2 with merge e2726c5...

xli
xli approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@xli xli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all tests passed

@github-actions
Copy link

Cluster Test Result

all up : 1031 TPS, 4396 ms latency, 5550 ms p99 latency, no expired txns

Repro cmd:

./scripts/cti --tag land_e2726c57 --run bench

@bors-libra
Copy link
Contributor

☀️ Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: xli
Pushing e2726c5 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xli xli xli approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefallentree @xli @bors-libra