Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate comments for LIP-6 #94

Merged
merged 2 commits into from Dec 3, 2020
Merged

Incorporate comments for LIP-6 #94

merged 2 commits into from Dec 3, 2020

Conversation

valerini
Copy link
Contributor

@valerini valerini commented Dec 3, 2020

No description provided.

@valerini valerini changed the title Incorporate comments Incorporate comments for LIP-6 Dec 3, 2020
@valerini valerini requested a review from davidiw December 3, 2020 01:01
Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, let's trim the Validator Operator OP_1 text and the tweaks and I think we are golden.

lips/lip-6.mdx Outdated Show resolved Hide resolved

Validator Owners are all members of the Association.

LN and LA will jointly manage the LibraRoot account. The LibraRoot account determines the composition of the Validator Set at any given time. Reasons for changing the Validator Set include new members joining the Association or existing members leaving the Association, possible suspension of Validator Owners for violating their Validator Agreement.

# Framework Guide
## Terminology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommended to alphabetize

lips/lip-6.mdx Outdated Show resolved Hide resolved
lips/lip-6.mdx Outdated Show resolved Hide resolved
lips/lip-6.mdx Outdated Show resolved Hide resolved
lips/lip-6.mdx Outdated Show resolved Hide resolved
lips/lip-6.mdx Outdated Show resolved Hide resolved
lips/lip-6.mdx Outdated Show resolved Hide resolved
@davidiw davidiw marked this pull request as ready for review December 3, 2020 20:29
@davidiw davidiw merged commit 9360886 into diem:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants