-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No mention of the many regular expression engines in use nor the engine used in the lesson's examples #71
Comments
+1 I often note this in my workshops but it would be great to reference one or two the links that you point to for more information. Can you see a point in the lesson where we can add this? |
I think adding 2-3 sentences in the lesson's opening paragraph would be sufficient and then maybe adding the links to the Key Points section. |
@andrewrs Would you be willing and able to recommend some text? I'm aware that there are different flavours of regex, but you seem to no more about the details than I do. |
Here's my first crack at some text:
I'll see if I can write something a little more tight over the next couple days when I'm not suffering from Friday afternoon brain fade. I also came across another nice reference at: https://gist.github.com/CMCDragonkai/6c933f4a7d713ef712145c5eb94a1816 |
add callout on regex engine per discussion at #71
Many thanks. I like it. Shall we go with:
I suggest we add it between '..including markdown and HTML.' and 'A very simple use of a regular expression..' at https://librarycarpentry.org/lc-data-intro/04-regular-expressions/index.html as a pinned callout (like 'Tab for Auto-complete' at https://librarycarpentry.org/lc-shell/03-working-with-files-and-folders/index.html). PR here #73 |
Yeah, I was thinking that placing the new text between '..including markdown and HTML.' and 'A very simple use of a regular expression..' too. I forked and the previously referenced regex feature comparison and separated the feature categories into their own tables to allow for easier scrolling: I like your edits and additions and I think version you posted is good to go. Yesterday, I revised my initial draft to come up with:
Sorry for the delay in posting the revision. Github apparently determined that my final edits to the regex table mentioned above weren't adequately human-like and locked my account for a day until I could customer service to unlock it. Feel free to pick and choose from either version. Again, I think the version you posted is perfectly sufficient. |
Light edit of text based on revision from @andrewrs at #71 (comment)
@andrewrs Woah, weird bot drama! I've incorporated your revised text into the PR. Ta! |
Resolved by #73 |
add callout on regex engine per discussion at #71
Light edit of text based on revision from @andrewrs at #71 (comment)
I'd recommend mentioning, at least in passing, that there are many different regular expression engines in common use and that each engine has features and syntax that, while often quite similar, do differ from each other in meaningful ways.
Additionally, there is no mention of the specific engine used for the lesson's examples. Granted, the basic examples used in the lesson will work with any Perl-like engine (with the lesson's suggested online tools employing PCRE and Javascript for the most part), it would be a good thing to plant the idea in the head of students that they might need to learn a particular tool or language's regular expression implementation before using more advanced regex features.
A couple links that describe the varying features of some of the many regular expression engines in use:
https://en.wikipedia.org/wiki/Comparison_of_regular_expression_engines (basic overview as one would expect on wikipedia)
https://www.regular-expressions.info/refflavors.html (nice, detailed reference)
The text was updated successfully, but these errors were encountered: