Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Episode 1 against Carpentries style guide #46

Closed
ostephens opened this issue Apr 30, 2019 · 6 comments
Closed

Review Episode 1 against Carpentries style guide #46

ostephens opened this issue Apr 30, 2019 · 6 comments
Labels
good first issue Good issue for first-time contributors

Comments

@ostephens
Copy link
Contributor

Carpentries now has a style guide
https://docs.carpentries.org/topic_folders/communications/style-guide.html

Review Episode 1 (https://github.com/LibraryCarpentry/lc-open-refine/blob/gh-pages/_episodes/01-introduction.md) to ensure it follows the style guide

@ostephens ostephens added the good first issue Good issue for first-time contributors label Apr 30, 2019
@jyssy
Copy link
Contributor

jyssy commented May 10, 2019

I am going to hazard a walk out the wild side and suggest Episode 1 conforms to the style guide currently.

@ostephens
Copy link
Contributor Author

Hi @jyssy - have you reviewed it against the style guide?

@jyssy
Copy link
Contributor

jyssy commented May 10, 2019

Yep, that was the goal of the issue for these episodes, correct? To make sure it conforms to the style guide? It looks like it does from top to bottom. I will work my way through more episodes if you think this one and # 2 are okay. thank you

@ostephens
Copy link
Contributor Author

If you've reviewed against the style guide and there are no changes to make you can just say you've done it and close the issue :)

@ostephens
Copy link
Contributor Author

If you find there are changes to make you can either make a note in the issue or make a PR to fix the issues

@ostephens
Copy link
Contributor Author

Ah - if you don't see the option I guess you don't have permission - sorry!

I'll close now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

2 participants