Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 6: Working with columns and sorting #94

Closed
fionaglasgow opened this issue Aug 6, 2019 · 1 comment · Fixed by #221
Closed

Episode 6: Working with columns and sorting #94

fionaglasgow opened this issue Aug 6, 2019 · 1 comment · Fixed by #221
Labels
good first issue Good issue for first-time contributors

Comments

@fionaglasgow
Copy link

Kia ora,

As part of the checkout process I propose a minor change to Chapter 6: Working with columns and sorting.

I suggest a minor change of wording relating to re-order vs reorder:

You can re-order the columns by clicking the drop-down menu at the top of the first column (labelled ‘All’), and choosing Edit columns->Re-order / remove columns …

You can then drag and drop column names to re-order the columns, or remove columns completely if they are not required.

to be replaced by:

You can reorder the columns by clicking the drop-down menu at the top of the first column (labelled ‘All’), and choosing Edit columns->Re-order / remove columns …

You can then drag and drop column names to reorder the columns, or remove columns completely if they are not required.

Motivation for suggested change:

There are two variations on "reorder" in use on this page, which, while minor, is inconsistent.

It might be worth having a discussion to see which way it goes, ie, the "reorders" could be changed to "re-orders", given that that is how it is spelled in OpenRefine, even though I don't believe that is technically grammatically correct. The remainder of the lesson uses reorder, for what it's worth.

Fiona Glasgow
Research Support Librarian
University of Otago

@fionaglasgow fionaglasgow reopened this Aug 6, 2019
@ostephens ostephens added the good first issue Good issue for first-time contributors label Aug 6, 2019
@ostephens
Copy link
Contributor

ostephens commented Aug 6, 2019

Thanks @fionaglasgow

I agree this should be consistent throughout and that reorder (non-hyphenated) is the correct, or at least more common, form.

Apart from where the text is specifically reproducing the terminology from OpenRefine (eg directing the user to a menu) I think we should use ‘reorder’

A PR to this effect would be welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants