Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 9: Transformations - Undo and Redo #95

Closed
jomtov opened this issue Aug 6, 2019 · 4 comments
Closed

Episode 9: Transformations - Undo and Redo #95

jomtov opened this issue Aug 6, 2019 · 4 comments
Labels
good first issue Good issue for first-time contributors

Comments

@jomtov
Copy link

jomtov commented Aug 6, 2019

Episode 9

To:

If you wish to save a set of steps to be re-applied later, or to a different project, you can click the Extract button. This gives you the option to select the steps you want to save, and to copy the transformations included in the selected steps in a format called ‘JSON’

suggestion add:

You can copy the Extracted JSON and save as a simple text-file (e.g. in Notepad) for later re-use.
(Tips: save with a filename that helps you remember the steps involved, for example
authorSplitANDmassEditPublisher.txt )

Motivation for suggested addition: it is not clear now how to save selected steps, and it also might give the impression that the file has to be saved as xxx.json

@ostephens
Copy link
Contributor

Thanks @jomtov

I think the sentence about pasting and saving in a file is a good addition. I’m slightly less sure about the tip in file naming as I think people should be free (and are able) to decide on their own naming / filing process - but I maybe being too picky!

I think a PR to make this change would be great

@ostephens ostephens added the good first issue Good issue for first-time contributors label Aug 6, 2019
@dpdong19
Copy link

dpdong19 commented Nov 13, 2019

Thank you for the suggestion! I like the proposed changes which may reduce confusion. However I think direct addition may make it a bit lengthy and repetitive. May I suggest merging the original and the added part with some wording changes as below:

"If you wish to save a set of steps to be re-applied later, or to a different project, you can click the Extract button. This gives you the option to select steps that you want to save, and extract the codes for those steps in a format called ‘JSON’. You can copy the extracted JSON and save it as a simple text file (e.g. in Notepad)."

I also agree with @ostephens that perhaps we can leave out the file naming suggestion here - even though itself is an important matter worthy of separate discussion. We may want to be less prescriptive here and keep it concise. What do you think?

libcce added a commit that referenced this issue Nov 13, 2019
Implement @dpdong19's suggestion on issue #95
@libcce
Copy link
Contributor

libcce commented Nov 13, 2019

Thanks @dpdong19 I've created a PR based on your nice suggestion #123

@ostephens or someone else want to review/approve?

ostephens added a commit that referenced this issue Nov 14, 2019
@ostephens
Copy link
Contributor

Closed by #123

zkamvar pushed a commit that referenced this issue May 1, 2023
Implement @dpdong19's suggestion on issue #95
zkamvar pushed a commit that referenced this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

4 participants