Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Reservation not possible #54

Closed
Steffeng5 opened this issue Jun 4, 2021 · 4 comments
Closed

Create Reservation not possible #54

Steffeng5 opened this issue Jun 4, 2021 · 4 comments

Comments

@Steffeng5
Copy link

Steffeng5 commented Jun 4, 2021

After updating from 2.7.* to 2.8.5.3 it is not possible to create reservations anymore.
WebInspector shows a parsing error:
Bildschirmfoto 2021-06-04 um 10 09 47

reservation.php is rendered with a warning of a pdf library:
Bildschirmfoto 2021-06-04 um 10 12 10

this results in bad html where it is not possible to click the "Create" Button to create the reservation

@Steffeng5
Copy link
Author

Steffeng5 commented Jun 4, 2021

This can be hotfixed by changing tpl/reservation/pdf.tpl by checking 2 variables if they are an array:
126: {if $ShowReservationDetails && is_array($Accessories) && $Accessories|count > 0}

262: {if is_array($Attachments) && $Attachments|count > 0}

Not sure if this is the true fix, but it helps to hide the warning appearing in the DOM

@Steffeng5 Steffeng5 reopened this Jun 4, 2021
@Steffeng5
Copy link
Author

This is a duplicate of #40 : Can you create a 2.8.5.4 with this PR?

@effgarces
Copy link
Collaborator

Could you check if the same problem occurs using the current pdf.tpl in the develop branch?

@Steffeng5
Copy link
Author

See above :) It is a duplicate of #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants