Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some embedded YT videos do not work #689

Closed
Moonstone3010 opened this issue May 3, 2023 · 3 comments
Closed

Some embedded YT videos do not work #689

Moonstone3010 opened this issue May 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Moonstone3010
Copy link

Some types of embedding (incorrect I think) make the frame non-clickable.

Video embedded in iframe in format:
https://www.youtube.com/embed/XxXXXXXxX
works with LibRedirect

Video embedded without iframe in format:
https://youtu.be/XxXXXXXxX
displays a locked video with a play button that does not work.
However, after disabling LibRedirect the youtube video can be played.

@ManeraKai ManeraKai added the bug Something isn't working label May 9, 2023
@ManeraKai
Copy link
Member

ManeraKai commented May 15, 2023

Is this happening in just one specific website? Show me a real example bc it there are a ton of different causes for this to happen.

@Moonstone3010
Copy link
Author

The page where I found the problematic links is quite complicated and requires a login. There is no direct link, it is part of a course. I can describe what you need to do one by one - if you want to, but you probably don't.

@ManeraKai
Copy link
Member

ManeraKai commented May 16, 2023

I see. I inspected the code, there's nothing that should cause this problem. I can assume it's bc of your "complicated course website". Those "complicated websites" don't embed in the normal way, they add something on top you (additional layer you can say), that's why if you had a different data response to that embed, it will break. I experienced this before with twitter embeds I believe.

Embeds are in general a headache:

  1. The main website won't accept instances responses bc of CSP
  2. Embeds break bc of a top layer on top on them (your case mostly)
  3. Instances themselves aren't configured to allow to be embedded
  4. They fingerprint LibRedirect. That's why we disabled them by default.

So yeah... I think I'm gonna close the issue. I really don't have a solution for it nor for the other issues about embeds.

@ManeraKai ManeraKai closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants