New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting YouTube Redirect Type to only embedded breaks youtube.com #392
Comments
It's not happening to me. Maybe it got fixed along the way but we didn't release it yet. |
I have a similar issue but the page just ends up mostly empty, just some very basic YT UI elements. The browser console is filled with errors Piped:
Invidious:
I'm using Firefox 104.0b4 but also reproduced this behavior with Vivaldi 5.3.2679.70. I got the same behavior initially as the original issue reporter when hitting F5 but refreshing without cache gave the same effect as Firefox where the page is mostly blank. I don't know a lot about extensions but I have a feeling this is where the issue is: It got refactored as part of this commit 2a0596f#diff-b0213f0fbd87e7fec7c8e4db0854ce29fcf63e8005264dc74f01107a5dd40130 so I thought I'd build against master and see what happens. I followed the instructions to build the zip, created my hypothetical 2.2.2 version and YouTube now works... because the extension is completely broken. It doesn't redirect embedded YouTube at all (even after resetting extension settings). @ManeraKai if you can share a working dev extension zip I'd be happy to test it out. |
xD. I think because you didn't run |
Yeah well that should be in the instructions then lol. This seems to have the same issues as the version I built:
|
I think I should remove the "only embedded" option all together. |
Here is what I have set for youtube:
I get this when I go to youtube.com, same issue with any frontend:
Works again after I disable youtube redirects.
The text was updated successfully, but these errors were encountered: