Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance addition/change for non-cloudflare official kavin.rocks #614

Closed
1 task
Kostrol opened this issue Feb 3, 2023 · 10 comments
Closed
1 task

Instance addition/change for non-cloudflare official kavin.rocks #614

Kostrol opened this issue Feb 3, 2023 · 10 comments

Comments

@Kostrol
Copy link

Kostrol commented Feb 3, 2023

Current (double listed) piped.video instances of are both tagged cloudflare in libredirect, however Piped has a claimed non-cloudflare version of kavin.rocks here. https://pipedapi-libre.kavin.rocks/ https://github.com/TeamPiped/Piped/wiki/Instances

I have already favorited this instance myself, but think this should be natively implemented within the instance lists for PSA and security.

@ManeraKai
Copy link
Member

Well bc it's redirecting to piped.video every time I try opening it.

@Kostrol
Copy link
Author

Kostrol commented Feb 3, 2023

@ManeraKai Yeah this is very odd.. I can't answer to why it seems to be under the same domain but they do appear to use different apis when you inspect it with ublock's dynamic filtering... the "cloudflared" instance uses

  • pipedapi.kavin.rocks
  • pipedproxy.kavin.rocks

Rimgo screenshot

Meanwhile however with my saved instance within libredirect uses

  • pipedapi-libre.kavin.rocks
  • pipedproxy-ams-2.kavin.rocks

Rimgo screenshot

It's very strange, because when you do click what i linked to be the "libre" it does appear to redirect to the one that only uses the
pipedapi.kavin.rock now.. I don't remember it doing that before.

So I guess they are actually just straight up lying..? Very unfortunate.

@ManeraKai
Copy link
Member

pipedproxy-ams-2.kavin.rocks is behind cloudlfare

So I guess they are actually just straight up lying..? Very unfortunate.

No I think there's a misconfiguration or something.

@FireMasterK

@FireMasterK
Copy link

pipedproxy-ams-2.kavin.rocks is behind cloudlfare

So I guess they are actually just straight up lying..? Very unfortunate.

No I think there's a misconfiguration or something.

@FireMasterK

It's not behind Cloudflare. The IP simply isn't even Cloudflare.

image
image

@ManeraKai
Copy link
Member

It's not behind Cloudflare. The IP simply isn't even Cloudflare.

Right, sorry.

@ManeraKai
Copy link
Member

The instances fetcher gets redirected to piped.video, so it assumes the "web frontend" is piped.video and adds it to the list. Now I know why I'm having the issue of a duplicate entry xD.
I think I will just add it as the default option. I won't modify the instances fetcher.

@Kostrol
Copy link
Author

Kostrol commented Feb 6, 2023

Still issues with configuration. But that might be on Piped's end, no?

There seems to be an issue with the redirection, I'm having issues when switching instances and embedded links.
https://youtube.com/watch?example --> https://pipedapi-libre.kavin.rocks/watch?example (404)

Again,
pipedapi-libre.kavin.rocks
pipedproxy-ams-2.kavin.rocks

Both now gone from the instance, what happened between my posting and now? Impossible to differentiate anymore with the domain.

I'm not conspiracy minded but it's a funny coincidence that they are just gone the minute my original post went up. :)

@FireMasterK
Copy link

The problem is Libredirect doesn't have a proper understanding of Piped's API, but instead tries to redirect to a frontend of Piped.

The thing is each frontend instance of Piped is designed to be able to connect to any API instance of Piped. For example, you can can go to https://piped.video/preferences and switch instances in the bottom of the page. This is the official and recommended way to use Piped, since frontends could be potentially modified by instance operators in a harmful manner, and there's no way to check the frontend's code.

The Piped frontend is also available through a few other officially hosted means, such as IPFS, Tor, and a few Clearweb mirrors.

What I'd recommend libredirect to do, is allow choosing a frontend and backend independently. (You can set the backend independently through localstorage)

@Kostrol
Copy link
Author

Kostrol commented Feb 6, 2023

Ah, of course. Now I understand what happened; the preferences. Thanks for clearing that up.

@ManeraKai
Copy link
Member

The thing is each frontend instance of Piped is designed to be able to connect to any API instance of Piped. For example, you can can go to https://piped.video/preferences and switch instances in the bottom of the page. This is the official and recommended way to use Piped, since frontends could be potentially modified by instance operators in a harmful

I know this, but people wanted it to be like that anyway.

The Piped frontend is also available through a few other officially hosted means, such as IPFS, Tor, and a few Clearweb mirrors.

Didn't know it's on IPFS too, interesting.

What I'd recommend libredirect to do, is allow choosing a frontend and backend independently. (You can set the backend independently through localstorage)

I will see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants