Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential security issue #425

Closed
JamieSlome opened this issue Mar 23, 2022 · 6 comments
Closed

Potential security issue #425

JamieSlome opened this issue Mar 23, 2022 · 6 comments

Comments

@JamieSlome
Copy link

Hey there!

I belong to an open source security research community, and a member (@peacock-doris) has found an issue, but doesn’t know the best way to disclose it.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)
@rurban
Copy link
Contributor

rurban commented Mar 23, 2022

send it to me, @rurban as mentioned in SECURITY.md

Reini

@JamieSlome
Copy link
Author

@rurban - sent to your e-mail on your GitHub profile 👍

Just for reference, the report can be found here:
https://huntr.dev/bounties/4ada4519-c3b6-4814-b822-65dcb33cf98d/

It is private and only accessible to maintainers with repository write permissions, if not using the protected URL sent in the e-mail.

@rurban
Copy link
Contributor

rurban commented Mar 24, 2022 •
edited

Hi
Can you ask @peacock-doris, with which commit exactly she found it? In my current master the line numbers don't matchup.

rurban added a commit that referenced this issue Mar 24, 2022
@rurban
indxf: fix use-after-free in the pair error-return design
fa4a343 
E.g. GH #425. On errors don't free pair and use pair.
pair = NULL announces success, on error return the pair.

add a EXPECT_UINT_DXF check esp. for BL. signed BL values have
the type BLd.
@JamieSlome
Copy link
Author

Dropped a comment on the report @rurban - thanks 👍

@JamieSlome
Copy link
Author

@rurban - the researcher has specified the commit on the report 👍

@rurban
Copy link
Contributor

rurban commented Apr 14, 2022

Fixed in master thanks

@rurban rurban closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rurban @JamieSlome