Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTYPE.strings_area up/downconverters needed? #910

Closed
rurban opened this issue Dec 31, 2023 · 2 comments
Closed

LTYPE.strings_area up/downconverters needed? #910

rurban opened this issue Dec 31, 2023 · 2 comments
Assignees
@rurban
Labels
bug Something isn't working

Comments

@rurban
Copy link
Contributor

rurban commented Dec 31, 2023

One of the last remaining heap-buffer-overflows without illegal input (fuzzing). Normally only encountered with in_dxf.
e.g. OUT=3 examples/llvmfuzz_standalone ../test/test-data/2018/ltype.dxf or
OUT=0 VER=8 examples/llvmfuzz_standalone ../test/test-data/2018/ltype.dxf
@rurban rurban self-assigned this Dec 31, 2023
@rurban rurban added the bug Something isn't working label Dec 31, 2023
@rurban
Copy link
Contributor Author

rurban commented Dec 31, 2023

Wrong. The output version was R_INVALID (missing). Just setting it fixed this asan error.

rurban added a commit that referenced this issue Dec 31, 2023
@rurban
Fix missing json dat->version
ed14bfa 
Fixes GH #910
rurban added a commit that referenced this issue Dec 31, 2023
@rurban
in_dxf: fix LTYPE.strings_area for r2007+
dfe3e19 
Fixes GH #910
@rurban rurban changed the title LTYPE.strings_area up/downconverters needed LTYPE.strings_area up/downconverters needed? Dec 31, 2023
rurban added a commit that referenced this issue Dec 31, 2023
@rurban
encode: add convert_LTYPE_strings_area
6960ff2 
for 256/512 byte conversions.
See GH #910
@rurban
Copy link
Contributor Author

rurban commented Jan 2, 2024

Implemented convert_LTYPE_strings_area

@rurban rurban closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rurban rurban

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rurban