New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bootstraps own img-responsive class for responsive graphs #2633
Conversation
Auto-Deploy finished, Test PR at http://2633.ci.librenms.org or https://2633.ci.librenms.org |
Does this negate the need for #2537? |
@laf Yup, does not need the $w and $h values either. |
Auto-Deploy finished, Test PR at http://2633.ci.librenms.org or https://2633.ci.librenms.org |
1 similar comment
Auto-Deploy finished, Test PR at http://2633.ci.librenms.org or https://2633.ci.librenms.org |
I just tested this PR and it is indeed working very well. The only downside is that the bootstrap responsive code doesn't upscale image. Which anyway isn't something we want as it would blur graphs. But this means that graphs are still tiny on big resolutions. So I also tested the changes in the PR on top of the one I have in PR #2537 which looks quite good to me and avoid my ugly workaround to reduce the blur on graphs. Current master behavior (resolution 2560x1440): With this PR : With this PR + PR #2537 ; |
Use bootstraps own img-responsive class for responsive graphs
Old: http://i.imgur.com/ZKHurbZ.png
When img-responsive is used: http://i.imgur.com/R6sTtiV.png
Automatically resizes as well when I resize the window: http://i.imgur.com/G5QxZN7.png