Toner graph does not escape colons causing rrdgraph to fail

[ghost]

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

• Is your install up to date? Updating your install
  Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
• Please include all of the information between the ==================================== section of ./validate.php.

LibreNMS Version: 243f9401f7b33fbeee55e01171af713b687c6691
DB Schema: 148
PHP: 7.0.12
MySQL: 10.1.18-MariaDB
RRDTool: 1.5.6
SNMP: NET-SNMP 5.7.3

• Please provide as much detail as possible.

Good day,

So this fun Samsung printer reports it's toner level happily these days. However librenms can't graph it. I believe this is due to $toner_id being set to "Toner S/N:CRUM-16021314488". That unfortunately has a : in it which rrdgraph seems to take as a colon divider. I've tried tracking down where toner_id was set to see if perhaps I could escape the : but I've not had luck so far.

This is the rrdtool output from the failed graph in librenms.

RRDTool Command
rrdtool graph /tmp/oTMJmTRVJvuUfcB4.png -l 0 -u 100 -E --start 1477233600 --end 1477320000 --width 1164 --height 300 -c BACK#EEEEEE00 -c SHADEA#EEEEEE00 -c SHADEB#EEEEEE00 -c FONT#000000 -c CANVAS#FFFFFF00 -c GRID#a5a5a5 -c MGRID#FF9999 -c FRAME#5e5e5e -c ARROW#5e5e5e -R normal --font LEGEND:8:DejaVuSansMono --font AXIS:7:DejaVuSansMono --font-render-mode normal COMMENT:' Cur Max\n' DEF:toner2=/opt/librenms/rrd/scribe.internal/toner-1.rrd:toner:AVERAGE LINE1:toner2#bf5d5b:'Toner S/N:CRUM-16021314488' AREA:toner2#bbd392: GPRINT:toner2:LAST:'%5.0lf%%' GPRINT:toner2:MAX:%5.0lf%%\\l

RRDTool Output
ERROR: Unused Arguments "CRUM-16021314488" in command : LINE1:toner2#bf5d5b:Toner S/N:CRUM-16021314488

It does poll the information correctly as the printer is reporting 82% toner left in librenms. It just can't generate this graph.

[ghost]

Im going to close this as the merged commits above solved the problem. :-).