New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: timezone support for graylog #7799
Conversation
Not sure I like the way this is fixed. I think they should just be displayed in the timezone of the browser accessing them. Which means the translation should probably be done in javascript with moment.js |
but in that case won't it be forced to user? maybe there are some that still would like to get the exact data as graylog stores them |
If you don't want to force it on the user, you should add a timezone setting to the user settings. With browser timezone as the default. That is a much larger scope. Up to you. |
@murrant: so I made it like: if no timezone is set in config, print default user timezone using moment.js. is this better? |
Any reason why you've removed my name from the copyright? |
By mistake, copy/paste the entire copyright section, restored it. Sorry |
Yeah, seems a like a good compromise for now. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. One little change from me.
I've also posted in the original issue for testers. If we don't hear from someone in a few days then I'm happy to merge in.
html/includes/table/graylog.inc.php
Outdated
/* | ||
* LibreNMS | ||
* Librenms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really petty but this should still be LibreNMS
The inspection completed: No new issues |
This thread has been automatically locked since there has not been any recent activity after it was closed. |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
feature request from community site
before:
after: