Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: timezone support for graylog #7799

Merged
merged 6 commits into from Dec 4, 2017
Merged

feature: timezone support for graylog #7799

merged 6 commits into from Dec 4, 2017

Conversation

crcro
Copy link
Contributor

@crcro crcro commented Nov 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

feature request from community site

before:
screen shot 2017-11-26 at 4 40 06 pm

after:
screen shot 2017-11-26 at 4 39 45 pm

@crcro crcro changed the title added timezone support for graylog feature: timezone support for graylog Nov 26, 2017
@murrant
Copy link
Member

murrant commented Nov 27, 2017

Not sure I like the way this is fixed. I think they should just be displayed in the timezone of the browser accessing them. Which means the translation should probably be done in javascript with moment.js

@murrant
Copy link
Member

murrant commented Nov 27, 2017

@crcro
Copy link
Contributor Author

crcro commented Nov 27, 2017

but in that case won't it be forced to user? maybe there are some that still would like to get the exact data as graylog stores them

@murrant
Copy link
Member

murrant commented Nov 28, 2017

If you don't want to force it on the user, you should add a timezone setting to the user settings. With browser timezone as the default.

That is a much larger scope. Up to you.

@crcro
Copy link
Contributor Author

crcro commented Nov 28, 2017

@murrant: so I made it like:

if no timezone is set in config, print default user timezone using moment.js.
if timezone is set then display using php date functions.

is this better?

@laf
Copy link
Member

laf commented Nov 29, 2017

Any reason why you've removed my name from the copyright?

@crcro
Copy link
Contributor Author

crcro commented Nov 29, 2017

By mistake, copy/paste the entire copyright section, restored it. Sorry

@murrant
Copy link
Member

murrant commented Dec 1, 2017

Yeah, seems a like a good compromise for now. Thanks.

Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. One little change from me.

I've also posted in the original issue for testers. If we don't hear from someone in a few days then I'm happy to merge in.

/*
* LibreNMS
* Librenms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really petty but this should still be LibreNMS

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@laf laf merged commit 0cb3470 into librenms:master Dec 4, 2017
@crcro crcro deleted the feature-graylog-timezone branch December 4, 2017 08:01
@lock
Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants