Add Mikrotik LLDP discovery

[erotel]

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

RouterOS must be > 6.38

[laf]

Nice work @erotel :)

out of interest can the other LLDP code further down not be re-used?

[erotel]

Standard LLDP can not be used because Mikrotik does not meet the LLDP standard

[laf]

Standard LLDP can not be used because Mikrotik does not meet the LLDP standard

Oh how I laughed :(

[murrant]

Do not unconditionally do 3 snmpwalks here.

If the first one fails, there is no point in doing the other two.

[murrant]

Looks great @erotel, looks good to merge after the small change I mentioned

[erotel]

@laf The Mikrotik has a lot of things wrong

standart lldp in edge core

root@speedtest:/opt/librenms# snmpwalk -v2c -c public -OQUsetX -m LLDP-MIB -M /opt/librenms/mibs:/opt/librenms/mibs/mikrotik udp:192.168.224.224:161 lldpRemTable
lldpRemChassisIdSubtype[0][5][5] = 5
lldpRemChassisIdSubtype[0][5][9] = 4
lldpRemChassisIdSubtype[0][24][4] = 7
lldpRemChassisIdSubtype[0][24][6] = 7
lldpRemChassisIdSubtype[0][27][3] = 4
lldpRemChassisId[0][5][5] = "01 0A 85 54 C6 "
lldpRemChassisId[0][5][9] = "00 1B B1 04 B6 50 "
lldpRemChassisId[0][24][4] = "RAy17_L"
lldpRemChassisId[0][24][6] = "RAy17_U"
lldpRemChassisId[0][27][3] = "CC 37 AB C4 5D 30 "
lldpRemPortIdSubtype[0][5][5] = 3
lldpRemPortIdSubtype[0][5][9] = 5
lldpRemPortIdSubtype[0][24][4] = 7
lldpRemPortIdSubtype[0][24][6] = 7
lldpRemPortIdSubtype[0][27][3] = 3

and Mikrotik

root@speedtest:/opt/librenms# snmpwalk -v2c -c public -OQUsetX -m LLDP-MIB -M /opt/librenms/mibs:/opt/librenms/mibs/mikrotik udp:10.133.0.8:161 lldpRemTable
lldpRemChassisIdSubtype[1] = 4
lldpRemChassisIdSubtype[2] = 4
lldpRemChassisIdSubtype[3] = 4
lldpRemChassisIdSubtype[4] = 4
lldpRemChassisIdSubtype[5] = 4
lldpRemChassisIdSubtype[6] = 4
lldpRemChassisIdSubtype[7] = 4
lldpRemChassisIdSubtype[8] = 4
lldpRemChassisIdSubtype[10] = 4
lldpRemChassisIdSubtype[11] = 4
lldpRemChassisIdSubtype[12] = 4
lldpRemChassisIdSubtype[13] = 4

[laf]

Just one change from me then good to go.

[laf]

May as well move the foreach ($lldp_array) into this if check, no point in even attempting to loop through the empty array.

[scrutinizer-notifier]

The inspection completed: 2 new issues

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed.