Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify How Custom Instances Are Configured #27

Closed
Airradda opened this issue Jan 28, 2024 · 3 comments
Closed

Clarify How Custom Instances Are Configured #27

Airradda opened this issue Jan 28, 2024 · 3 comments

Comments

@Airradda
Copy link

It would be help if it clarified in the README or the configuration popup's field, Custom Instance (Optional), what format the instance URL is supposed to be in. I was about ready to switch back to Libredirect as the addon was ignoring my custom instances and directing me to the same rate limited ones. It took me reading through the code to find that it should be example.com with no prefix or trailing slash and so you can't simply copy paste from the URL bar or a link.

@libreom
Copy link
Owner

libreom commented Jan 28, 2024

Thanks for feedback, This is needed, what should be written in your opinion? For eg- "Custom Instance (eg- nitter.net)" or anything else. I'll clarify first in README, then in input area, and will also add validation and error handling it it's not written the right way

@Airradda
Copy link
Author

Something like "Custom Instance (eg- nitter.net)" would work since I think "Custom" indicates it being optional pretty well.

@libreom
Copy link
Owner

libreom commented Apr 3, 2024

Already Completed with 3ced4fc It has not been released and likely won't be in a month, but one can give feedback by running extension from master branch or
image

@libreom libreom closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants