Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container names are fixed and can not be changed #12

Closed
jswetzen opened this issue May 7, 2021 · 1 comment · Fixed by #42
Closed

Container names are fixed and can not be changed #12

jswetzen opened this issue May 7, 2021 · 1 comment · Fixed by #42
Labels
enhancement New feature or request

Comments

@jswetzen
Copy link

jswetzen commented May 7, 2021

I'm managing my whole server with docker-compose, and as such the container names frontend, backend and proxy can be confusing/conflicting with the rest of my setup. I manually changed the compose file, but realized that those names are hard-coded into the images.

To me it would make a whole lot of sense to be able to run LibrePhotos with different container names, especially with environment variables like BACKEND_HOST already in the backend compose config that suggest that it would be configurable.

@derneuere derneuere added the enhancement New feature or request label Sep 21, 2021
@joe-eklund
Copy link

joe-eklund commented Oct 11, 2021

Just wanted to chime in here about how I got this working with custom container names.

I inserted librephotos in my custom docker compose file that has all my other apps, and as such did not want to have them named frontend, etc.

After changing the container names to librephotos-frontend, etc. I ran into the problem that the proxy could not find the backend. I then copied the nginx conf file and modified it to reference librephotos-backend wherever backend was. I then mounted the nginx conf file through a docker volume to /etc/nginx/nginx.conf in the librephotos proxy container.

You also need to make sure that you have the correct BACKEND_HOST variable set in your environment for the librephotos-backend container, otherwise you will run into the issue in LibrePhotos/librephotos#152.

This does mean I will have to keep an eye on any nginx conf changes and make them on my custom file before I docker pull in any new changes, but this is fine since it is worth it to have all my apps on one master docker compose file. Everything seems to be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants