Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move window scrollbar only works for the first row #24

Closed
derneuere opened this issue Dec 9, 2020 · 1 comment
Closed

Move window scrollbar only works for the first row #24

derneuere opened this issue Dec 9, 2020 · 1 comment
Labels
bug Something isn't working frontend

Comments

@derneuere
Copy link
Member

This attempts to move the window scrollbar to the photo when clicking the arrow buttons in the photo viewer or keyboard keys and that is a good idea, however as implemented it only works correctly for the first row of photos in any day:
https://github.com/LibrePhotos/librephotos-frontend/blob/dev/src/layouts/%5C#L378-L391
@derneuere derneuere added bug Something isn't working frontend labels Dec 9, 2020
@derneuere
Copy link
Member Author

Seems to work now. Probably got fixed by reloading the picture to reframe it in the middle.

AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
@derneuere
Merge pull request LibrePhotos#24 from jmalm/refactor-photos-in-redux
72e4969 
Refactor photos in redux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derneuere